[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set |
Date: |
Sat, 15 Dec 2018 20:00:47 +1100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Dec 13, 2018 at 12:03:49AM -0500, Emilio G. Cota wrote:
> Cc: David Gibson <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: address@hidden
> Reviewed-by: Richard Henderson <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
Acked-by: David Gibson <address@hidden>
> ---
> target/ppc/translate.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 2b37910248..4bb78f403e 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -1609,8 +1609,7 @@ GEN_LOGICAL2(nor, tcg_gen_nor_tl, 0x03, PPC_INTEGER);
> static void gen_pause(DisasContext *ctx)
> {
> TCGv_i32 t0 = tcg_const_i32(0);
> - tcg_gen_st_i32(t0, cpu_env,
> - -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
> + gen_helper_cpu_halted_set(cpu_env, t0);
> tcg_temp_free_i32(t0);
>
> /* Stop translation, this gives other CPUs a chance to run */
> @@ -3584,8 +3583,7 @@ static void gen_sync(DisasContext *ctx)
> static void gen_wait(DisasContext *ctx)
> {
> TCGv_i32 t0 = tcg_const_i32(1);
> - tcg_gen_st_i32(t0, cpu_env,
> - -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
> + gen_helper_cpu_halted_set(cpu_env, t0);
> tcg_temp_free_i32(t0);
> /* Stop translation, as the CPU is supposed to sleep from now */
> gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v5 03/73] cpu: introduce cpu_mutex_lock/unlock, (continued)
- [Qemu-devel] [PATCH v5 03/73] cpu: introduce cpu_mutex_lock/unlock, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 02/73] cpu: rename cpu->work_mutex to cpu->lock, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 07/73] cpu: make per-CPU locks an alias of the BQL in TCG rr mode, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 01/73] cpu: convert queued work to a QSIMPLEQ, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 04/73] cpu: make qemu_work_cond per-cpu, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 11/73] hppa: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 10/73] cris: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 05/73] cpu: move run_on_cpu to cpus-common, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- Re: [Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set,
David Gibson <=
- [Qemu-devel] [PATCH v5 12/73] m68k: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 27/73] xtensa: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 16/73] tcg-runtime: convert to cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 24/73] riscv: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 08/73] tcg-runtime: define helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 21/73] lm32: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 15/73] cpu: define cpu_halted helpers, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 19/73] sh4: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 13/73] alpha: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 14/73] microblaze: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/12/13