[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed members |
Date: |
Thu, 13 Dec 2018 15:56:27 +0100 |
On Thu, 13 Dec 2018 12:02:52 +0000
Peter Maydell <address@hidden> wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang warn about this.
>
> Avoid the problem by using local copies of the PMCW and SCSW
> struct fields in copy_schib_from_guest() and copy_schib_to_guest().
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> v1->v2 changes:
> * add comment about why we're using locals
> * name locals with underscores, as QEMU's naming conventions recommend
>
>
> hw/s390x/css.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
Thanks, applied.