Re: [Qemu-devel] [PATCH v10 5/9] block: treat BDRV_REQ_ALLOCATE as serialising

[Anton Nefedov]

On 12/12/2018 3:48 PM, Vladimir Sementsov-Ogievskiy wrote:
> 05.12.2018 17:01, Anton Nefedov wrote:
>> --- a/include/block/block.h
>> +++ b/include/block/block.h
>> @@ -87,6 +87,9 @@ typedef enum {
>>          * efficiently allocate the space so it reads as zeroes, or return
>> an error.
>>          * If this flag is set then BDRV_REQ_ZERO_WRITE must also be set.
>>          * This flag cannot be set together with BDRV_REQ_MAY_UNMAP.
>> +     * This flag implicitly behaves as BDRV_REQ_SERIALISING i.e. it is
>> +     * protected from conflicts with overlapping requests. If such
>> conflict is
>> +     * detected, -EAGAIN is returned.
> 
> "behaves as" sounds like "do the same" for me, so better is "implicitly sets" 
> or something like this.
> 

"implicitly sets" is good enough for me