[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input o
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input or --mailback |
Date: |
Wed, 12 Dec 2018 16:22:24 +0100 |
In some cases, checkpatch's process subroutine is exiting the
whole process. This is wrong, just return from the subroutine
instead.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 60f6f89..b9974f0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2820,19 +2820,19 @@ sub process {
# If we have no input at all, then there is nothing to report on
# so just keep quiet.
if ($#rawlines == -1) {
- exit(0);
+ return 1;
}
# In mailback mode only produce a report in the negative, for
# things that appear to be patches.
if ($mailback && ($clean == 1 || !$is_patch)) {
- exit(0);
+ return 1;
}
# This is not a patch, and we are are in 'no-patch' mode so
# just keep quiet.
if (!$chk_patch && !$is_patch) {
- exit(0);
+ return 1;
}
if (!$is_patch) {
--
1.8.3.1
- [Qemu-devel] [PULL 00/54] Misc patches for 2018-12-12, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 01/54] accel: Improve selection of the default accelerator, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 11/54] hax: Support for Linux hosts, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 04/54] checkpatch: check Signed-off-by in --mailback mode, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 09/54] memory: avoid unnecessary coalesced_io_del operations, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 08/54] memory: extract flat_range_coalesced_io_{del, add}, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 14/54] block/iscsi: fix ioctl cancel use-after-free, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 05/54] checkpatch: improve handling of multiple patches or files, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 20/54] build-sys: build with Vista API by default, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 07/54] pam: wrap MemoryRegion initialization in a transaction, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input or --mailback,
Paolo Bonzini <=
- [Qemu-devel] [PULL 06/54] checkpatch: colorize output to terminal, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 25/54] qemu/queue.h: do not access tqe_prev directly, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 24/54] compiler.h: Add an explicit check for the compiler version, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 13/54] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events(), Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 16/54] esp-pci: Fix status register write erase control, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 15/54] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 02/54] vhost-user-bridge: fix "unknown type name" compilation error, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 26/54] vfio: make vfio_address_spaces static, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 22/54] test: execute g_test_run when tests are skipped, Paolo Bonzini, 2018/12/12