qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input o


From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 03/54] checkpatch: fix premature exit when no input or --mailback
Date: Wed, 12 Dec 2018 16:22:24 +0100

In some cases, checkpatch's process subroutine is exiting the
whole process.  This is wrong, just return from the subroutine
instead.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 60f6f89..b9974f0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2820,19 +2820,19 @@ sub process {
        # If we have no input at all, then there is nothing to report on
        # so just keep quiet.
        if ($#rawlines == -1) {
-               exit(0);
+               return 1;
        }
 
        # In mailback mode only produce a report in the negative, for
        # things that appear to be patches.
        if ($mailback && ($clean == 1 || !$is_patch)) {
-               exit(0);
+               return 1;
        }
 
        # This is not a patch, and we are are in 'no-patch' mode so
        # just keep quiet.
        if (!$chk_patch && !$is_patch) {
-               exit(0);
+               return 1;
        }
 
        if (!$is_patch) {
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]