[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Pe
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2) |
|
Date: |
Wed, 12 Dec 2018 13:03:22 +0100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 12.12.2018 um 09:59 hat Olaf Hering geschrieben:
> On Fri, Nov 02, Kevin Wolf wrote:
>
> > A while ago, a downstream patch review found out that there are some QMP
> > commands that would immediately crash if a xen_disk device were present
> > because of the lacking qdevification. This is not the code quality
> > standard I envision for QEMU. It's time for non-qdev devices to go.
>
> Do you have that backwards by any chance? IMO the presence of assert()
> contributes to bad code quality, not the drivers that trigger those
> asserts.
You like shooting the messenger, it seems? Bugs aren't bad, only
catching them is?
But anyway, in this case, I seem to remember it was a plain old
segfault, not a failed assertion.
Kevin
signature.asc
Description: PGP signature