[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/11] colo: check chardev can switch context
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 05/11] colo: check chardev can switch context |
Date: |
Wed, 12 Dec 2018 11:11:39 +0100 |
From: Marc-André Lureau <address@hidden>
COLO uses a worker context (iothread) to drive the chardev. All
backends are not able to switch the context, let's report an error in
this case.
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Li Zhijian <address@hidden>
Reviewed-by: Zhang Chen <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
net/colo-compare.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index a39191d522..9156ab3349 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr,
return 1;
}
+ if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
+ error_setg(errp, "chardev \"%s\" cannot switch context",
+ chr_name);
+ return 1;
+ }
+
return 0;
}
--
2.17.2
- [Qemu-devel] [PULL 00/11] Monitor patches for 2018-12-12, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 02/11] monitor: accept chardev input from iothread, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 06/11] monitor: prevent inserting new monitors after cleanup, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 04/11] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 05/11] colo: check chardev can switch context,
Markus Armbruster <=
- [Qemu-devel] [PULL 03/11] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 01/11] monitor: inline ambiguous helper functions, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 10/11] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 08/11] monitor: Suspend monitor instead dropping commands, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 07/11] monitor: avoid potential dead-lock when cleaning up, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 11/11] tests: add oob functional test for test-qmp-cmds, Markus Armbruster, 2018/12/12
- [Qemu-devel] [PULL 09/11] monitor: Remove "x-oob", offer capability "oob" unconditionally, Markus Armbruster, 2018/12/12
- Re: [Qemu-devel] [PULL 00/11] Monitor patches for 2018-12-12, Peter Maydell, 2018/12/13