[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine |
Date: |
Tue, 11 Dec 2018 17:22:32 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Dec 11, 2018 at 06:56:39PM +0530, P J P wrote:
> From: Prasad J Pandit <address@hidden>
>
> Define skeleton 'uar_read' routine. Avoid NULL dereference.
>
> Reported-by: Li Qiang <address@hidden>
> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
> hw/rdma/vmw/pvrdma_main.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index ca5fa8d981..a6211d416d 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -455,6 +455,11 @@ static const MemoryRegionOps regs_ops = {
> },
> };
>
> +static uint64_t uar_read(void *opaque, hwaddr addr, unsigned size)
> +{
> + return 0;
> +}
> +
> static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size)
> {
> PVRDMADev *dev = opaque;
> @@ -496,6 +501,7 @@ static void uar_write(void *opaque, hwaddr addr, uint64_t
> val, unsigned size)
> }
>
> static const MemoryRegionOps uar_ops = {
> + .read = uar_read,
Are you sure it is needed?
Looking at memory_region_dispatch_read1 i can see that there is a check but
not sure this is the right place. Anyways, if it is not, i believe this
should be framework responsibility.
> .write = uar_write,
> .endianness = DEVICE_LITTLE_ENDIAN,
> .impl = {
> --
> 2.19.2
>
- [Qemu-devel] [PATCH 0/5] rdma: various issues in rdma/pvrdma backend, P J P, 2018/12/11
- [Qemu-devel] [PATCH 1/5] rdma: check that num_sge does not exceed MAX_SGE, P J P, 2018/12/11
- [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine, P J P, 2018/12/11
- Re: [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine,
Yuval Shaia <=
- [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/12
[Qemu-devel] [PATCH 3/5] pvrdma: check number of pages when creating rings, P J P, 2018/12/11