[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb-audio: ignore usb packages with wrong size
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb-audio: ignore usb packages with wrong size |
|
Date: |
Tue, 11 Dec 2018 09:10:35 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/11/18 8:26 AM, Gerd Hoffmann wrote:
> usb packets with no payload (zero length) seem to happen in practice for
> whatever reason. Add a check and skip the packet then, otherwise we'll
> trigger an assert.
>
> Reported-by: Leonardo Soares Müller <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/usb/dev-audio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
> index ee43e4914d..28ac7c5165 100644
> --- a/hw/usb/dev-audio.c
> +++ b/hw/usb/dev-audio.c
> @@ -321,6 +321,9 @@ static int streambuf_put(struct streambuf *buf, USBPacket
> *p)
> if (!free) {
> return 0;
> }
> + if (p->iov.size != USBAUDIO_PACKET_SIZE) {
> + return 0;
> + }
> assert(free >= USBAUDIO_PACKET_SIZE);
> usb_packet_copy(p, buf->data + (buf->prod % buf->size),
> USBAUDIO_PACKET_SIZE);
>