[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU-devel][PATCH v2] aio-posix: Fix concurrent aio_po
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [QEMU-devel][PATCH v2] aio-posix: Fix concurrent aio_poll/set_fd_handler. |
|
Date: |
Mon, 10 Dec 2018 19:05:48 +0000 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Dec 06, 2018 at 11:14:23AM +0100, address@hidden wrote:
> + if (is_new) {
> + new_node->pfd.fd = fd;
> + } else {
> + deleted = aio_remove_fd_handler(ctx, node);
> + new_node->pfd = node->pfd;
Does this drop revents? Imagine revents has bits set, then
aio_remove_fd_handler() will clear them and new_node->pfd = node->pfd is
too late to preserve them.
signature.asc
Description: PGP signature