[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_compani
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_companions to hw/i386 |
|
Date: |
Mon, 10 Dec 2018 18:37:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 10/12/18 14:17, Gerd Hoffmann wrote:
> On Fri, Nov 30, 2018 at 10:45:12PM +0100, Paolo Bonzini wrote:
>> This function is only needed when Q35 is in use. Moving it to
>> the same file that uses it lets you disable the entire USB
>> subsystem in x86_64-softmmu.mak; of course doing that will
>> cause -usb to break horribly, but one thing at a time.
>
> Patch doesn't apply.
>
>> - if (0 && machine_usb(machine)) {
>> + if (machine_usb(machine)) {
>
> Leftover local debug change here?
Yes, more precisely this patch replaced the quick "0 &&" hack.
Paolo