Re: [Qemu-devel] [PATCH for-4.0 v7 11/27] qapi: pass long form enum to make_enum_members

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> This will allow to get rid of short form handling in a following
> patch.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Suggested-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi/common.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index fdc0fd69ef..557b413950 100644
> --- a/scripts/qapi/common.py
> +++ b/scripts/qapi/common.py
> @@ -1663,9 +1663,10 @@ class QAPISchema(object):
>          self.the_empty_object_type = QAPISchemaObjectType(
>              'q_empty', None, None, None, None, [], None)
>          self._def_entity(self.the_empty_object_type)
> -        qtype_values = self._make_enum_members(['none', 'qnull', 'qnum',
> -                                                'qstring', 'qdict', 'qlist',
> -                                                'qbool'])
> +
> +        qtypes = ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 
> 'qbool']

Long line.

> +        qtype_values = self._make_enum_members([{'name': n} for n in qtypes])
> +
>          self._def_entity(QAPISchemaEnumType('QType', None, None, None,
>                                              qtype_values, 'QTYPE'))

We may want to squash this one into PATCH 08 as mentioned in that
patch's review.

In case we don't:
Reviewed-by: Markus Armbruster <address@hidden>