[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data fo
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] mac_newworld: enable access to EDID data for the VGA device |
Date: |
Mon, 10 Dec 2018 14:46:42 +1100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Dec 07, 2018 at 04:08:05PM +0000, Mark Cave-Ayland wrote:
> This is in preparation for some upcoming QEMU NDRV driver changes that pass
> display information from the host to the guest.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
This looks fine by my limited knowledge of this area. I'm slightly
perturbed I can't see any existing examples in the tree of setting the
edid property from the machine.
> ---
> hw/ppc/mac_newworld.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> index 14273a123e..df0a2f03ff 100644
> --- a/hw/ppc/mac_newworld.c
> +++ b/hw/ppc/mac_newworld.c
> @@ -430,7 +430,10 @@ static void ppc_core99_init(MachineState *machine)
> }
> }
>
> - pci_vga_init(pci_bus);
> + dev = qdev_create(BUS(pci_bus), "VGA");
> + qdev_prop_set_int32(dev, "addr", -1);
> + qdev_prop_set_bit(dev, "edid", true);
> + qdev_init_nofail(dev);
>
> if (graphic_depth != 15 && graphic_depth != 32 && graphic_depth != 8) {
> graphic_depth = 15;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
[Qemu-devel] [PATCH 1/3] MAINTAINERS: add myself as maintainer for Mac Old World and New World machines, Mark Cave-Ayland, 2018/12/07