[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk'
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom' |
Date: |
Fri, 7 Dec 2018 14:35:25 +0000 |
User-agent: |
Mutt/1.11.1 (2018-12-01) |
On Thu, Dec 06, 2018 at 03:08:29PM +0000, Paul Durrant wrote:
> +static char *disk_to_vbd_name(unsigned int disk)
> +{
> + char *name, *prefix = (disk >= 26) ?
> + disk_to_vbd_name((disk / 26) - 1) : g_strdup("");
> +
> + name = g_strdup_printf("%s%c", prefix, 'a' + disk);
I don't think that works, if disk is 27, we do ('a' + 27) here. It's
probably missing a `disk % 26`.
> + g_free(prefix);
> +
> + return name;
> +}
[...]
> +static unsigned int vbd_name_to_disk(const char *name, const char **endp)
> +{
> + unsigned int disk = 0;
> +
> + while (*name != '\0') {
> + if (!g_ascii_isalpha(*name) || !g_ascii_islower(*name)) {
> + break;
> + }
> +
> + disk *= 26;
> + disk += *name++ - 'a';
> + }
> + *endp = name;
> +
> + return disk;
> +}
> +
> +static void xen_block_set_vdev(Object *obj, Visitor *v, const char *name,
> + void *opaque, Error **errp)
> +{
Setting vdev doesn't work. I've tried to add a disk `xvdaa', and it
result in `xvda', or `d0p0' (in the trace). (Same result with `xvdaaa',
and 'xvdba' gives 'xvdaa'/d26p0)
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH v2 05/18] xen: add xenstore watcher infrastructure, (continued)
- [Qemu-devel] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 09/18] xen: remove unnecessary code from dataplane/xen-block.c, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 07/18] xen: add event channel interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 06/18] xen: add grant table interface for XenDevice-s, Paul Durrant, 2018/12/06
- [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/06
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom',
Anthony PERARD <=
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Anthony PERARD, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Daniel P . Berrangé, 2018/12/07
- Re: [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom', Paul Durrant, 2018/12/10
[Qemu-devel] [PATCH v2 15/18] xen: add a mechanism to automatically create XenDevice-s..., Paul Durrant, 2018/12/06
[Qemu-devel] [PATCH v2 14/18] xen: add implementations of xen-block connect and disconnect functions..., Paul Durrant, 2018/12/06