[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] checkpatch: warn about queue/queue.h head s
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] checkpatch: warn about queue/queue.h head structs that are not typedef-ed |
Date: |
Fri, 7 Dec 2018 14:49:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 07/12/18 10:02, Markus Armbruster wrote:
> Let's state the rationale for requiring a typedef in the commit
> message, or point to a prior commit that has it.
Sure---the rationale is simply that they are structs (or unions in the
case of QTAILQ but it's just an implementation detail), and we use
typedef for structs.
Paolo
> Paolo Bonzini <address@hidden> writes:
>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> scripts/checkpatch.pl | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a8d6e44107..b4b3495044 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -2263,6 +2263,11 @@ sub process {
>> }
>> }
>>
>> + if ($line =~
>> /^.\s*(Q(?:S?LIST|SIMPLEQ|TAILQ)_HEAD)\s*\(\s*[^,]/ &&
>> + $line !~ /^.typedef/) {
>> + ERROR("named $1 should be typedefed separately\n" .
>> $herecurr);
>> + }
>> +
>> # Need a space before open parenthesis after if, while etc
>> if ($line=~/\b(if|while|for|switch)\(/) {
>> ERROR("space required before the open parenthesis
>> '('\n" . $herecurr);
- Re: [Qemu-devel] [PATCH 3/6] qemu/queue.h: typedef QTAILQ heads, (continued)