[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] qemu/queue.h: do not access tqe_prev direct
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] qemu/queue.h: do not access tqe_prev directly |
Date: |
Fri, 7 Dec 2018 11:14:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/7/18 12:23 AM, Paolo Bonzini wrote:
> Use the QTAILQ_IN_USE macro instead, it does the same thing but the next
> patch will change it to a different definition.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> blockdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 81f95d920b..7604b2183b 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -4259,7 +4259,7 @@ void qmp_blockdev_del(const char *node_name, Error
> **errp)
> goto out;
> }
>
> - if (!bs->monitor_list.tqe_prev) {
> + if (!QTAILQ_IN_USE(bs, monitor_list)) {
> error_setg(errp, "Node %s is not owned by the monitor",
> bs->node_name);
> goto out;
>
- [Qemu-devel] [PATCH for-4.0 0/6] qemu/queue.h usage cleanup, improved QTAILQ API, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 1/6] qemu/queue.h: do not access tqe_prev directly, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 3/6] qemu/queue.h: typedef QTAILQ heads, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 2/6] qemu/queue.h: leave head structs anonymous unless necessary, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 5/6] qemu/queue.h: simplify reverse access to QTAILQ, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 4/6] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers, Paolo Bonzini, 2018/12/06
- [Qemu-devel] [PATCH 6/6] checkpatch: warn about queue/queue.h head structs that are not typedef-ed, Paolo Bonzini, 2018/12/06