Re: [Qemu-devel] [PATCH] aio_poll race condition.

[Philippe Mathieu-Daudé]

Hi Remy,
On 11/16/18 8:02 PM, address@hidden wrote:
> From: Remy Noel <address@hidden>
> 
> It is possible for an io_poll callback to be concurrently executed along
> with an aio_set_fd_handlers. This can cause all sorts of problems, like
> a NULL callback or a bad opaque pointer.
> We fixes that by using an remove/insert RCU scheme.

You forgot to Cc the relevant maintainers, that's probably why your
series went unnoticed.

>From the wiki:
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer

$ ./scripts/get_maintainer.pl -f include/block/aio.h util/aio-posix.c
util/aio-win32.c util/async.c
Stefan Hajnoczi <address@hidden> (supporter:Block I/O path)
Fam Zheng <address@hidden> (supporter:Block I/O path)
Kevin Wolf <address@hidden> (supporter:Block layer core)
Max Reitz <address@hidden> (supporter:Block layer core)
Stefan Weil <address@hidden> (maintainer:W32, W64)
address@hidden (open list:Block I/O path)
address@hidden (open list:All patches CC here)

Please Cc them in your v2.

(Note Fam has a new email: Fam Zheng <address@hidden>)

Regards,

Phil.

> 
> Please note that i did not test the win32 version.
> 
> Remy Noel (3):
>   aio-posix: Fix concurrent aio_poll/set_fd_handler.
>   util/aio-posix: Use RCU for handler insertion.
>   aio: Do not use list_lock as a sync mechanism for aio_handlers
>     anymore.
> 
>  include/block/aio.h |   4 +-
>  util/aio-posix.c    | 148 ++++++++++++++++++++------------------------
>  util/aio-win32.c    |  82 +++++++++---------------
>  util/async.c        |   7 ++-
>  4 files changed, 103 insertions(+), 138 deletions(-)
>