[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch c
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context |
Date: |
Thu, 06 Dec 2018 06:48:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
I'd like an Acked-by or Reviewed-by from Zhang Chen or Li Zhijian.
Marc-André Lureau <address@hidden> writes:
> COLO uses a worker context (iothread) to drive the chardev. All
> backends are not able to switch the context, let's report an error in
> this case.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> net/colo-compare.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index a39191d522..9156ab3349 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr,
> return 1;
> }
>
> + if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
> + error_setg(errp, "chardev \"%s\" cannot switch context",
> + chr_name);
> + return 1;
> + }
> +
> return 0;
> }
- [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, (continued)
- [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/05
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
[Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context, Marc-André Lureau, 2018/12/05
[Qemu-devel] [PATCH for-4.0 v4 6/7] monitor: prevent inserting new monitors after cleanup, Marc-André Lureau, 2018/12/05
[Qemu-devel] [PATCH for-4.0 v4 7/7] monitor: avoid potential dead-lock when cleaning up, Marc-André Lureau, 2018/12/05
Re: [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes, Markus Armbruster, 2018/12/06