[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] tests/test-arm-mptimer: Don't leak string m
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] tests/test-arm-mptimer: Don't leak string memory |
Date: |
Tue, 4 Dec 2018 08:00:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/4/18 7:29 AM, Peter Maydell wrote:
> The test-arm-mptimer setup creates a lot of test names using
> g_strdup_printf() and never frees them. This is entirely
> harmless since it's one-shot test code, but it clutters
> up the output from clang's LeakSanitizer. Refactor to
> use a helper function so we can free the memory.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> tests/test-arm-mptimer.c | 153 ++++++++++++++++++---------------------
> 1 file changed, 69 insertions(+), 84 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/5] arm: five simple memory leak fixes, Peter Maydell, 2018/12/04
- [Qemu-devel] [PATCH 4/5] tests/test-arm-mptimer: Don't leak string memory, Peter Maydell, 2018/12/04
- [Qemu-devel] [PATCH 5/5] target/arm: Create timers in realize, not init, Peter Maydell, 2018/12/04
- [Qemu-devel] [PATCH 2/5] hw/arm/mps2-tz.c: Free mscname string in make_dma(), Peter Maydell, 2018/12/04
- [Qemu-devel] [PATCH 3/5] hw/sd/sdhci: Don't leak memory region in sdhci_sysbus_realize(), Peter Maydell, 2018/12/04
- [Qemu-devel] [PATCH 1/5] target/arm: Free name string in ARMCPRegInfo hashtable entries, Peter Maydell, 2018/12/04