[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop |
Date: |
Mon, 3 Dec 2018 09:47:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/1/18 6:30 AM, Peter Maydell wrote:
> Patchset structure:
> * patch 1 does the "make sure we have the iothread lock for
> calls into QEMU" (which is effectively a no-op initially
> since we'll already be holding that lock when our refresh
> etc callbacks are called)
> * patch 2 makes switchSurface directly take the pixman image
> (which is refcounted) rather than the DisplaySurface (which
> is not), so we can make the calls to it asynchronous later
> * patches 3 and 4 are just trivial code motion
> * patch 5 does the bulk of the work (and can't really be split
> further without the UI being broken at the intermediate point)
FWIW, this makes sense and is relatively easy to follow.
That said, I've never touched OSX at all, so can't even test.
r~
- [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop, Peter Maydell, 2018/12/01
- [Qemu-devel] [RFC 1/5] ui/cocoa: Ensure we have the iothread lock when calling into QEMU, Peter Maydell, 2018/12/01
- [Qemu-devel] [RFC 5/5] ui/cocoa: Perform UI operations only on the main thread, Peter Maydell, 2018/12/01
- [Qemu-devel] [RFC 3/5] ui/cocoa: Factor out initial menu creation, Peter Maydell, 2018/12/01
- [Qemu-devel] [RFC 4/5] ui/cocoa: Move console/device menu creation code up in file, Peter Maydell, 2018/12/01
- [Qemu-devel] [RFC 2/5] ui/cocoa: Use the pixman image directly in switchSurface, Peter Maydell, 2018/12/01
- Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop,
Richard Henderson <=
- Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop, Gerd Hoffmann, 2018/12/05