[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure from
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure from patch_reloc |
Date: |
Mon, 03 Dec 2018 10:40:34 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.90 |
Richard Henderson <address@hidden> writes:
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> tcg/i386/tcg-target.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
> index 5c88f1f36b..28192f4608 100644
> --- a/tcg/i386/tcg-target.inc.c
> +++ b/tcg/i386/tcg-target.inc.c
> @@ -175,7 +175,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
> case R_386_PC32:
> value -= (uintptr_t)code_ptr;
> if (value != (int32_t)value) {
> - tcg_abort();
> + return false;
> }
> /* FALLTHRU */
> case R_386_32:
> @@ -184,7 +184,7 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
> case R_386_PC8:
> value -= (uintptr_t)code_ptr;
> if (value != (int8_t)value) {
> - tcg_abort();
> + return false;
> }
> tcg_patch8(code_ptr, value);
> break;
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure from patch_reloc,
Alex Bennée <=