[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU cou
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow |
|
Date: |
Fri, 30 Nov 2018 12:43:34 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 11/30/18 11:57 AM, Aaron Lindsay wrote:
>> Eh? But we've set overflow_mask based on PMCR.LC, so what you say here
>> doesn't
>> make sense.
>
> Sorry, I had an off-by-one-bit think-o I couldn't get past until I
> started typing a concrete example to explain myself. I'll change this
> line to be:
>
> if (!(env->cp15.c9_pmcr & PMCRLC))
> new_pmccntr &= 0xffffffff;
Ah, much better. Thanks.
r~
- [Qemu-devel] [PATCH v8 08/13] target/arm: Add array for supported PMU events, generate PMCEID[01]_EL0, (continued)
- [Qemu-devel] [PATCH v8 08/13] target/arm: Add array for supported PMU events, generate PMCEID[01]_EL0, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 12/13] target/arm: Implement PMSWINC, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 09/13] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 10/13] target/arm: PMU: Add instruction and cycle events, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 13/13] target/arm: Send interrupts on PMU counter overflow, Aaron Lindsay, 2018/11/20