[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 03/13] target/arm: Swap PMU values before/aft
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v8 03/13] target/arm: Swap PMU values before/after migrations |
Date: |
Fri, 30 Nov 2018 16:07:31 +0000 |
On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay
<address@hidden> wrote:
>
> Because of the PMU's design, many register accesses have side effects
> which are inter-related, meaning that the normal method of saving CP
> registers can result in inconsistent state. These side-effects are
> largely handled in pmu_op_start/finish functions which can be called
> before and after the state is saved/restored. By doing this and adding
> raw read/write functions for the affected registers, we avoid
> migration-related inconsistencies.
>
> Signed-off-by: Aaron Lindsay <address@hidden>
> Signed-off-by: Aaron Lindsay <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v8 00/13] More fully implement ARM PMUv3, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 01/13] migration: Add post_save function to VMStateDescription, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 05/13] target/arm: Allow AArch32 access for PMCCFILTR, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 03/13] target/arm: Swap PMU values before/after migrations, Aaron Lindsay, 2018/11/20
- Re: [Qemu-devel] [PATCH v8 03/13] target/arm: Swap PMU values before/after migrations,
Peter Maydell <=
- [Qemu-devel] [PATCH v8 06/13] target/arm: Implement PMOVSSET, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 02/13] target/arm: Reorganize PMCCNTR accesses, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 04/13] target/arm: Filter cycle counter based on PMCCFILTR_EL0, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 07/13] target-arm: Make PMCEID[01]_EL0 64 bit registers, add PMCEID[23], Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 11/13] target/arm: PMU: Set PMCR.N to 4, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 08/13] target/arm: Add array for supported PMU events, generate PMCEID[01]_EL0, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 12/13] target/arm: Implement PMSWINC, Aaron Lindsay, 2018/11/20
- [Qemu-devel] [PATCH v8 09/13] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER, Aaron Lindsay, 2018/11/20