[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding c
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface |
Date: |
Fri, 30 Nov 2018 15:56:10 +0000 |
On Wed, 28 Nov 2018 at 03:50, Peng Hao <address@hidden> wrote:
>
> Prepare for pvpanic-mmio configure interface.
>
> Signed-off-by: Peng Hao <address@hidden>
> ---
> hw/arm/sysbus-fdt.c | 2 ++
> hw/arm/virt.c | 2 ++
> hw/misc/pvpanic.c | 11 +++++++++--
> 3 files changed, 13 insertions(+), 2 deletions(-)
This looks rather odd. The sysbus-fdt.c code is for
handling devices that we must pass through from the
host system (including pulling in device tree fragments
from the host). The pvpanic device isn't a host pass
through device so I don't think it should be touching
that code at all. It's just a simple MMIO device.
I suspect the reason you've done this is that you're
trying to get "-device pvpanic" to work on the command
line. I recommend not trying to get that to work.
MMIO devices are not pluggable devices, and -device
is not expected to work with them.
thanks
-- PMM
- [Qemu-devel] [PATCH V10 4/9] hw/arm/virt: Use the pvpanic device, (continued)
- [Qemu-devel] [PATCH V10 4/9] hw/arm/virt: Use the pvpanic device, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 6/9] hw/misc/pvpanic: add configure query interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 9/9] pvpanic : update pvpanic document, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 8/9] hw/misc/pvpanic: realize the configure interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface, Peng Hao, 2018/11/27
- Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface,
Peter Maydell <=