Re: [Qemu-devel] [PATCH v2 4/5] x86: exit qemu if load_image fails

[Peter Maydell]

On Wed, 21 Nov 2018 at 02:11, Li Zhijian <address@hidden> wrote:
>
> CC: Paolo Bonzini <address@hidden>
> CC: Richard Henderson <address@hidden>
> CC: Eduardo Habkost <address@hidden>
> CC: "Michael S. Tsirkin" <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Li Zhijian <address@hidden>
> ---
>  hw/i386/pc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index f095725..2ffe6fb 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -984,7 +984,10 @@ static void load_linux(PCMachineState *pcms,
>          initrd_addr = (initrd_max-initrd_size) & ~4095;
>
>          initrd_data = g_malloc(initrd_size);
> -        load_image(initrd_filename, initrd_data);
> +        if (load_image(initrd_filename, initrd_data) < 0) {
> +            fprintf(stderr, "failed to load initrd\n");
> +            exit(1);
> +        }

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM