[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" bac
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0] 9p: remove support for the "handle" backend |
Date: |
Fri, 30 Nov 2018 10:05:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-30 09:49, Greg Kurz wrote:
> The "handle" fsdev backend was deprecated in QEMU 2.12.0 with:
>
> commit db3b3c7281ca82e2647e072a1f97db111313dd73
> Author: Greg Kurz <address@hidden>
> Date: Mon Jan 8 11:18:23 2018 +0100
>
> 9pfs: deprecate handle backend
>
> This backend raise some concerns:
>
> - doesn't support symlinks
> - fails +100 tests in the PJD POSIX file system test suite [1]
> - requires the QEMU process to run with the CAP_DAC_READ_SEARCH
> capability, which isn't recommended for security reasons
>
> This backend should not be used and wil be removed. The 'local'
> backend is the recommended alternative.
>
> [1] https://www.tuxera.com/community/posix-test-suite/
>
> Signed-off-by: Greg Kurz <address@hidden>
> Reviewed-by: Daniel P. Berrange <address@hidden>
> Reviewed-by: Aneesh Kumar K.V <address@hidden>
>
> It has passed the two release cooling period without any complaint.
>
> Remove it now.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>
> It could have been removed for 3.1.0, but I woke up too late, so moving
> this to 4.0.
>
> ---
> fsdev/qemu-fsdev.c | 3
> hw/9pfs/9p-handle.c | 710
> -------------------------------------------------
> hw/9pfs/Makefile.objs | 1
> qemu-deprecated.texi | 8 -
> qemu-options.hx | 8 -
> 5 files changed, 4 insertions(+), 726 deletions(-)
> delete mode 100644 hw/9pfs/9p-handle.c
Reviewed-by: Thomas Huth <address@hidden>