[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 2/4] checkpatch: check Signed-off-by in
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 2/4] checkpatch: check Signed-off-by in --mailback mode |
Date: |
Thu, 29 Nov 2018 15:04:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 29/11/18 10:01, Paolo Bonzini wrote:
> Pull the test before the anticipated exits from the process sub.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/checkpatch.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d58fcb1efd..c216c55e01 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2866,6 +2866,10 @@ sub process {
> }
> }
>
> + if ($is_patch && $chk_signoff && $signoff == 0) {
> + ERROR("Missing Signed-off-by: line(s)\n");
> + }
> +
> # If we have no input at all, then there is nothing to report on
> # so just keep quiet.
> if ($#rawlines == -1) {
> @@ -2887,9 +2891,6 @@ sub process {
> if (!$is_patch) {
> ERROR("Does not appear to be a unified-diff format patch\n");
> }
> - if ($is_patch && $chk_signoff && $signoff == 0) {
> - ERROR("Missing Signed-off-by: line(s)\n");
> - }
>
> print report_dump();
> if ($summary && !($clean == 1 && $quiet == 1)) {
>
- [Qemu-devel] [PATCH for-4.0 0/4] Small checkpatch fixes and improvements, Paolo Bonzini, 2018/11/29
- [Qemu-devel] [PATCH for-4.0 1/4] checkpatch: fix premature exit when no input or --mailback, Paolo Bonzini, 2018/11/29
- [Qemu-devel] [PATCH for-4.0 3/4] checkpatch: improve handling of multiple patches or files, Paolo Bonzini, 2018/11/29
- [Qemu-devel] [PATCH for-4.0 4/4] checkpatch: colorize output to terminal, Paolo Bonzini, 2018/11/29
- [Qemu-devel] [PATCH for-4.0 2/4] checkpatch: check Signed-off-by in --mailback mode, Paolo Bonzini, 2018/11/29
- Re: [Qemu-devel] [PATCH for-4.0 0/4] Small checkpatch fixes and improvements, no-reply, 2018/11/30
- Re: [Qemu-devel] [PATCH for-4.0 0/4] Small checkpatch fixes and improvements, no-reply, 2018/11/30