Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

[Fei Li]

On 11/29/2018 04:35 PM, Markus Armbruster wrote:
> Fei Li <address@hidden> writes:
>
> > On 11/28/2018 08:53 PM, Markus Armbruster wrote:
> > > Fei Li <address@hidden> writes:
> > >
> > > > When qemu_signal_init() fails in qemu_init_main_loop(), we return
> > > > without setting an error.  Its callers crash then when they try to
> > > > report the error with error_report_err().
> > > Yes, that's a bug.  Broken in 2f78e491d7b, v2.2.0.  Has escaped notice
> > > since qemu_signalfd() is quite unlikely to fail.  Could go into 3.1 as a
> > > bug fix, but I think punting it to the next release is just fine.
> > Thanks. :) BTW, should I send the next version only includes patch 1/5
> > and 2/5 separately so that you can merge? (I guess Dave will help to
> > merge the other three migration related patches)
> I can pick patches out of a series for merging, and I trust Dave can,
> too.  But keeping unrelated fixes separate is a good idea.  I can see
> three groups: PATCH 1 (main loop), PATCH 2 (thread abstraction), PATCH
> 3-5 (migration).
>
> [...]
Ok, thanks for the detail explanation. I once thought the first two patches
are belong to one group, that's why I tried to separate them.
But considering too many groups they are belong to and maintainers are
willing to pick, I'd like to keep sending them within one patch series in
the next version. :)

Have a nice day, thanks a lot
Fei