[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from vir
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci |
Date: |
Wed, 28 Nov 2018 21:06:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 26/11/2018 20:59, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
>
> ---
>
> Remove the "contributions after" clause. This is based on
>
> commit 59ccd20a9ac719cff82180429458728f03ec612f
> Author: KONRAD Frederic <address@hidden>
> Date: Wed Apr 24 10:07:56 2013 +0200
> ---
> hw/virtio/Makefile.objs | 1 +
> hw/virtio/virtio-pci.c | 52 -----------------------
> hw/virtio/virtio-pci.h | 14 -------
> hw/virtio/virtio-rng-pci.c | 86 ++++++++++++++++++++++++++++++++++++++
> tests/Makefile.include | 1 +
> 5 files changed, 88 insertions(+), 66 deletions(-)
> create mode 100644 hw/virtio/virtio-rng-pci.c
...
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index fb0b449c02..e8235890ec 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -149,6 +149,7 @@ check-qtest-virtio-y += tests/virtio-net-test$(EXESUF)
> check-qtest-virtio-y += tests/virtio-balloon-test$(EXESUF)
> check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF)
> check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF)
> +check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF)
I think you should remove the line just above.
except that:
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH v2 00/16] Virtio devices split from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 02/16] virtio: split virtio input host bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 03/16] virtio: split virtio input bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci, Juan Quintela, 2018/11/26
- Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci,
Laurent Vivier <=
- [Qemu-devel] [PATCH v2 06/16] virtio: split virtio 9p bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 05/16] virtio: split virtio balloon bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 07/16] virtio: split vhost user blk bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 08/16] virtio: split vhost user scsi bits from virtio-pci, Juan Quintela, 2018/11/26
- [Qemu-devel] [PATCH v2 09/16] virtio: split vhost scsi bits from virtio-pci, Juan Quintela, 2018/11/26