qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v2 07/24] riscv: tcg-target: Add support for the c


From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC v2 07/24] riscv: tcg-target: Add support for the constraints
Date: Wed, 28 Nov 2018 11:33:14 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 11/27/18 1:07 PM, Alistair Francis wrote:
> +    OPC_FENCE_RW_RW = 0x0330000f,
> +    OPC_FENCE_R_R = 0x0220000f,
> +    OPC_FENCE_W_R = 0x0120000f,
> +    OPC_FENCE_R_W = 0x0210000f,
> +    OPC_FENCE_W_W = 0x0110000f,
> +    OPC_FENCE_R_RW = 0x0230000f,
> +    OPC_FENCE_RW_W = 0x0310000f,

A full compliment would have 9 alternatives, surely?
Perhaps better to just fill in the fields when emitting?

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]