Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize

[Palmer Dabbelt]

On Tue, 27 Nov 2018 17:46:04 PST (-0800), address@hidden wrote:
> Hi, Palmer
>
> On 11/28/18 8:34 AM, Palmer Dabbelt wrote:
> > On Mon, 26 Nov 2018 01:06:33 PST (-0800), Bastian Koppelmann wrote:
> > > On 11/26/18 4:20 AM, Mao Zhongyi wrote:
> > > > Signed-off-by: Mao Zhongyi <address@hidden>
> > > > ---
> > > >   target/riscv/cpu.c | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Reviewed-by: Bastian Koppelmann <address@hidden>
> >
> > Shouldn't we also use device_class_set_parent_reset right below this?
>
> device_class_set_parent_reset only used for DeviceClass *dc->reset, here
> is CPUClass *cc->reset.

Ah, OK, I didn't look closely enough.

> Thanks,
> Mao
>
> > Either
> > way, I'll queue this one for 3.2.
> >
> > Thanks!