Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

[Aleksandar Markovic]

Stefan Weil wrote:

> These two patches fix wrong format strings used in disas/nanomips.

Stefan,

I truly appreciate your interest in nanoMIPS dissasembler.

In my opinion, this series comes too late in 3.1 development cycle to be
accepted. The described severity of undesired behavior is just way too low
for rc3 phase.

Also, as a general remark, in this series, there is no example of wrong
output for big endian host, only some belief or opinion - referent test
example would be helpful, and much better justification for the series.
Some build errors are mentioned, but they are not a part for official
builds. Related to these errors, certain additional build options are said
to cause build warnings, but such build options were not identified.

All in all, my judgement is that we should deal with these issues after 3.1
release.

However, I am still grateful to you for bringing these issues up, and you
are welcome to participate in any way in future development of this and
other segments of QEMU for MIPS.

Yours,
Aleksandar
On Nov 27, 2018 1:19 PM, "Stefan Weil" <address@hidden> wrote:

> These two patches fix wrong format strings used in disas/nanomips.
>
> The first patch replaces proprietary data types by POSIX data types,
> because otherwise the PRI... macros cannot be used in the second patch.
>
> Those patches are only relevant for 3.1 if full nanomips support is
> considered
> important enought and if QEMU is used on big endian machines (I think
> the old code will work on little endian hosts even with wrong format
> strings).
>
> I use those patches for QEMU for Windows because that is compiled with
> more compiler warnings, so compilation would fail without the fix.
>
> Regards
> Stefan
>
>
>