Re: [Qemu-devel] [PATCH v6 00/13] hardfloat

[Emilio G. Cota]

On Tue, Nov 27, 2018 at 09:24:21 -0800, address@hidden wrote:
> /tmp/qemu-test/src/fpu/softfloat.c: In function 'f32_is_inf':
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: implicit declaration of 
> function 'isinff' [-Werror=implicit-function-declaration]
>          return isinff(a.h);
>                 ^~~~~~
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: incompatible implicit 
> declaration of built-in function 'isinff' [-Werror]
> cc1: all warnings being treated as errors
> /tmp/qemu-test/src/fpu/softfloat.c: In function 'f32_is_inf':
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: implicit declaration of 
> function 'isinff' [-Werror=implicit-function-declaration]
>          return isinff(a.h);
>                 ^~~~~~
> /tmp/qemu-test/src/fpu/softfloat.c:325:16: error: incompatible implicit 
> declaration of built-in function 'isinff' [-Werror]
> cc1: all warnings being treated as errors
> make[1]: *** [/tmp/qemu-test/src/rules.mak:69: fpu/softfloat.o] Error 1
> make[1]: *** [/tmp/qemu-test/src/rules.mak:69: fpu/softfloat.o] Error 1

This is the offender:

+static inline bool f32_is_inf(union_float32 a)
+{
+    if (QEMU_HARDFLOAT_USE_ISINF) {
+        return isinff(a.h);
+    }
+    return float32_is_infinity(a.s);
+}

I've fixed up the branch on github to use isinf here instead
of isinff.

                Emilio