[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/11] qcow2: encryption threads
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 00/11] qcow2: encryption threads |
Date: |
Tue, 27 Nov 2018 16:23:02 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Nov 23, 2018 at 07:55:00PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> The series brings threads to qcow2 encryption/decryption path,
> like it is already done for compression.
>
> Based-on: Kevin's block-next branch [d3db1496c5]
>
> Performance gain is illustrated by the following test:
>
> ]# cat test.sh
> #!/bin/bash
>
> size=1G
> src=/ssd/src.raw
> dst=/ssd/dst.enc.qcow2
>
> echo create source for tests
> ./qemu-img create -f raw "$src" $size
> ./qemu-io -f raw -c "write -P 0xa 0 $size" "$src"
>
> for w in "" "-W"; do
> echo -e "\n\nTest with additional paramter for qemu-img: '$w'\n"
>
> echo create target...
> ./qemu-img create -f qcow2 --object secret,id=sec0,data=test -o
> encrypt.format=luks,encrypt.key-secret=sec0,encrypt.iter-time=10 "$dst" $size
> echo
>
> echo test...
> time ./qemu-img convert $w -f raw --object secret,id=sec0,data=test
> --target-image-opts -n "$src"
> "driver=qcow2,file.filename=$dst,encrypt.key-secret=sec0"
> done
Note that using iter-time=10 is removing the time penalty for opening
the luks device. This is why you didn't see the significant negative
performance impact of creating many QCryptoBlock instances, one for
each thread.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH 07/11] qcow2-threads: add encryption, (continued)
- [Qemu-devel] [PATCH 07/11] qcow2-threads: add encryption, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 05/11] qcow2-threads: split out generic path, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 01/11] qcow2.h: add missing include, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 11/11] qcow2: do encryption in threads, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 08/11] qcow2: bdrv_co_preadv: improve locking, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 09/11] qcow2: qcow2_co_preadv: skip using hd_qiov when possible, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 04/11] qcow2: split out data processing threads state from BDRVQcow2State, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 02/11] qcow2: add separate file for threaded data processing functions, Vladimir Sementsov-Ogievskiy, 2018/11/23
- [Qemu-devel] [PATCH 10/11] qcow2: bdrv_co_pwritev: move encryption code out of the lock, Vladimir Sementsov-Ogievskiy, 2018/11/23
- Re: [Qemu-devel] [PATCH 00/11] qcow2: encryption threads,
Daniel P . Berrangé <=