Re: [Qemu-devel] [PULL 3/3] target/mips: Add disassembler support for nanoMIPS

[Peter Maydell]

On Thu, 8 Nov 2018 at 08:00, Stefan Weil <address@hidden> wrote:
>
> On 25.10.18 22:19, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <address@hidden>
> >
> > Add disassembler support for nanoMIPS.
> >
> > Reviewed-by: Stefan Markovic <address@hidden>
> > Signed-off-by: Matthew Fortune <address@hidden>
> > Signed-off-by: Aleksandar Markovic <address@hidden>
> > ---
> >  MAINTAINERS           |     2 +
> >  configure             |     3 +
> >  disas/Makefile.objs   |     1 +
> >  disas/nanomips.cpp    | 22242 
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> >  disas/nanomips.h      |  1099 +++
> >  include/disas/bfd.h   |     1 +
> >  include/exec/poison.h |     1 +
> >  target/mips/cpu.c     |    13 +-
> >  8 files changed, 23360 insertions(+), 2 deletions(-)
> >  create mode 100644 disas/nanomips.cpp
> >  create mode 100644 disas/nanomips.h
>
>
> Hi,
>
> the disassembler needs more work for the next QEMU release: it uses lots
> of wrong format strings which will result in wrong output at least on
> big endian hosts.

Hi Stefan; by "for the next QEMU release" do you mean:
(a) this is a release-critical bug which we need to fix for 3.1
(b) this is not critical for this release, but we should
fix it in the next release (4.0)

?

thanks
-- PMM