[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 2/3] kvm-all: Introduce kvm_set_singleste
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 2/3] kvm-all: Introduce kvm_set_singlestep |
Date: |
Fri, 23 Nov 2018 09:57:33 +0100 |
On Wed, 21 Nov 2018 16:13:46 -0200
Fabiano Rosas <address@hidden> wrote:
> This will be used in a future patch to implement an
> architecture-specific single step mechanism for POWER.
>
> Signed-off-by: Fabiano Rosas <address@hidden>
> ---
> accel/kvm/kvm-all.c | 10 ++++++++++
> exec.c | 1 +
> include/sysemu/kvm.h | 4 ++++
> target/arm/kvm.c | 4 ++++
> target/i386/kvm.c | 4 ++++
> target/mips/kvm.c | 4 ++++
> target/ppc/kvm.c | 4 ++++
> target/s390x/kvm.c | 4 ++++
> 8 files changed, 35 insertions(+)
>
> @@ -431,6 +433,8 @@ void kvm_arch_remove_all_hw_breakpoints(void);
>
> void kvm_arch_update_guest_debug(CPUState *cpu, struct kvm_guest_debug *dbg);
>
> +void kvm_arch_set_singlestep(CPUState *cpu, int enabled);
Might be useful to add a comment here that describes what common code
expects the arch-specific function to do here so they don't step on
each others toes.
> +
> bool kvm_arch_stop_on_emulation_error(CPUState *cpu);
>
> int kvm_check_extension(KVMState *s, unsigned int extension);