[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-3.2 3/4] build-sys: build with Vista API by defa
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH for-3.2 3/4] build-sys: build with Vista API by default |
Date: |
Thu, 22 Nov 2018 15:00:38 +0400 |
Both qemu & qga build with Vista API by default already, by defining
_WIN32_WINNT 0x0600. Set it globally in osdep.h instead.
This replaces WINVER by _WIN32_WINNT in osdep.h. WINVER doesn't seem
to be really useful these days.
(see also https://blogs.msdn.microsoft.com/oldnewthing/20070411-00/?p=27283)
Signed-off-by: Marc-André Lureau <address@hidden>
---
include/qemu/osdep.h | 4 ++--
qga/commands-win32.c | 6 +-----
util/qemu-thread-win32.c | 4 ----
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 7b6e5db9d0..80df7253db 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -76,8 +76,8 @@ extern int daemon(int, int);
#ifdef _WIN32
/* as defined in sdkddkver.h */
-#ifndef WINVER
-#define WINVER 0x0501 /* XP */
+#ifndef _WIN32_WINNT
+#define _WIN32_WINNT 0x0600 /* Vista */
#endif
/* reduces the number of implicitly included headers */
#ifndef WIN32_LEAN_AND_MEAN
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 62e1b51dfe..f03b9c1d89 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -10,12 +10,8 @@
* This work is licensed under the terms of the GNU GPL, version 2 or later.
* See the COPYING file in the top-level directory.
*/
-
-#ifndef _WIN32_WINNT
-# define _WIN32_WINNT 0x0600
-#endif
-
#include "qemu/osdep.h"
+
#include <wtypes.h>
#include <powrprof.h>
#include <winsock2.h>
diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
index 4a363ca675..572f88535d 100644
--- a/util/qemu-thread-win32.c
+++ b/util/qemu-thread-win32.c
@@ -11,10 +11,6 @@
*
*/
-#ifndef _WIN32_WINNT
-#define _WIN32_WINNT 0x0600
-#endif
-
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "qemu/thread.h"
--
2.20.0.rc1
- [Qemu-devel] [PATCH for-3.2 0/4] build-sys: require Vista API by default globally, Marc-André Lureau, 2018/11/22
- [Qemu-devel] [PATCH for-3.2 2/4] build-sys: move windows defines in osdep.h header, Marc-André Lureau, 2018/11/22
- [Qemu-devel] [PATCH for-3.2 1/4] build-sys: don't include windows.h, osdep.h does it, Marc-André Lureau, 2018/11/22
- [Qemu-devel] [PATCH for-3.2 3/4] build-sys: build with Vista API by default,
Marc-André Lureau <=
- [Qemu-devel] [PATCH for-3.2 4/4] RFC: qga: drop < Vista compatibility, Marc-André Lureau, 2018/11/22
- Re: [Qemu-devel] [PATCH for-3.2 0/4] build-sys: require Vista API by default globally, Paolo Bonzini, 2018/11/29