[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT bu
From: |
Samuel Ortiz |
Subject: |
Re: [Qemu-devel] [PATCH v5 15/24] hw: i386: Export the i386 ACPI SRAT build method |
Date: |
Thu, 22 Nov 2018 00:27:33 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:38 +0100
> Samuel Ortiz <address@hidden> wrote:
>
> > This is the standard way of building SRAT on x86 platfoms. But future
> > machine types could decide to define their own custom SRAT build method
> > through the ACPI builder methods.
> > Moreover, we will also need to reach build_srat() from outside of
> > acpi-build in order to use it as the ACPI builder SRAT build method.
> SRAT is usually highly machine specific (memory holes, layout, guest OS
> specific quirks) so it's hard to generalize it.
Hence the need for an SRAT builder interface.
> I'd drop SRAT related patches from this series and introduce
> i386/virt specific SRAT when you post patches for it.
virt uses the existing i386 build_srat() routine, there's nothing
special about it. So this would be purely duplicated code.
Cheers,
Samuel.
[Qemu-devel] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 18/24] hw: i386: Export the MADT build method, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 17/24] hw: acpi: Export the PCI hotplug API, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 21/24] hw: i386: Implement the ACPI builder interface for PC, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 20/24] hw: acpi: Define ACPI tables builder interface, Samuel Ortiz, 2018/11/04