qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock
Date: Wed, 21 Nov 2018 11:30:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:


I agree it is good to preserve fcntl flags though, so this patch
looks desirable.

Reviewed-by: Daniel P. Berrangé <address@hidden>

Sure

Acked-by: Michael S. Tsirkin <address@hidden>

but really not for this release I guess as we are in freeze.

We're in freeze, so the criteria is: Does this fix a bug that we would otherwise not want in 3.1. If the code is pre-existing (that is, if 3.0 was released with the same problem), or then delaying the patch to 4.0 is an easier call to make. If the problem is new to 3.1, then fixing it for -rc3 is still reasonable with maintainer discretion (although once -rc3 lands, we want as little as possible to go into -rc4, even if our track record says we will be unable to avoid -rc4 altogether).

I think that losing flags is likely enough to be a noticeable bug worth fixing for 3.1, but I did not research when the problem was introduced, so I don't have a strong preference for 3.1 vs. 4.0.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]