[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for R
From: |
Samuel Ortiz |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP |
Date: |
Wed, 21 Nov 2018 15:42:11 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Igor,
On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:28 +0100
> Samuel Ortiz <address@hidden> wrote:
>
> > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System
> > Description Table). RSDT only allow for 32-bit addressses and have thus
> > been deprecated. Since ACPI version 2.0, RSDPs should point at XSDTs and
> > no longer RSDTs, although RSDTs are still supported for backward
> > compatibility.
> >
> > Since version 2.0, RSDPs should add an extended checksum, a complete table
> > length and a version field to the table.
>
> This patch re-implements what arm/virt board already does
> and fixes checksum bug in the later and at the same time
> without a user (within the patch).
>
> I'd suggest redo it a way similar to FADT refactoring
> patch 1: fix checksum bug in virt/arm
> patch 2: update reference tables in test
> patch 3: introduce AcpiRsdpData similar to commit 937d1b587
> (both arm and x86) wich stores all data in hos byte order
> patch 4: convert arm's impl. to build_append_int_noprefix() API (commit
> 5d7a334f7)
>
> ... move out to aml-build.c
> patch 5: reuse generalized arm's build_rsdp() for x86, dropping x86
> specific one
> amending it to generate rev1 variant defined by revision in AcpiRsdpData
> (commit dd1b2037a)
I agree patches #1, #2 and #5 make sense. 3 and 4 as well, but here
you're asking about something that's out of scope of the current serie.
I'll move those patches from this serie and build a 6 patches new serie
as suggested.
Cheers,
Samuel.
- Re: [Qemu-devel] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void, (continued)
[Qemu-devel] [PATCH v5 06/24] hw: acpi: Factorize the RSDP build API implementation, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 08/24] hw: acpi: Factorize _OSC AML across architectures, Samuel Ortiz, 2018/11/04