Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

[Marc-André Lureau]

Hi

On Tue, Nov 20, 2018 at 4:57 AM Samuel Thibault
<address@hidden> wrote:
>
> g_spawn_async_with_fds is portable on Windows, so we can now enable
> fork_exec support there.
>
> Thanks Daniel P. Berrangé for the notice!
>
> Signed-off-by: Samuel Thibault <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  slirp/misc.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/slirp/misc.c b/slirp/misc.c
> index 7972b9b05b..59b4e8f31c 100644
> --- a/slirp/misc.c
> +++ b/slirp/misc.c
> @@ -62,17 +62,6 @@ int add_exec(struct ex_list **ex_ptr, void *chardev, const 
> char *cmdline,
>  }
>
>
> -#ifdef _WIN32
> -
> -int
> -fork_exec(struct socket *so, const char *ex)
> -{
> -    /* not implemented */
> -    return 0;
> -}
> -
> -#else
> -
>  static int
>  slirp_socketpair_with_oob(int sv[2])
>  {
> @@ -132,7 +121,9 @@ err:
>  static void
>  fork_exec_child_setup(gpointer data)
>  {
> +#ifndef _WIN32
>      setsid();
> +#endif
>  }
>
>  int
> @@ -177,7 +168,6 @@ fork_exec(struct socket *so, const char *ex)
>      qemu_set_nonblock(so->s);
>      return 1;
>  }
> -#endif
>
>  char *slirp_connection_info(Slirp *slirp)
>  {
> --
> 2.19.1
>