Re: [Qemu-devel] [PATCH RFC] MAINTAINERS: clarify some of the tags

[Eric Blake]

On 11/16/18 9:14 AM, Cornelia Huck wrote:

> > Recent threads have mentioned the possibility of potentially adding a
> > new category P: for the person that submits pull requests, although I'm
> > not quite sure how that is different from M: as a maintainer
>
> Let's wait how that discussion turns out (I'm not quite sure about the
> semantics, either.) We can document it then.

Indeed, incremental patches are better than doing nothing while waiting 
for perfection.

> > > > +++ b/MAINTAINERS
> > > > @@ -12,9 +12,14 @@ consult qemu-devel and not any specific individual privately.
> > > >    Descriptions of section entries:
> > > >    
> > > >    	M: Mail patches to: FullName <address@hidden>
> > > > +          Maintainers are looking after a certain area and must be CCed on
> > > > +          patches. They are considered the main contact point.
> >
> > Maybe add something along the lines of "However, a maintainer may accept
> > code that has been reviewed by others without explicitly reviewing it
> > themselves"?
>
> I'm not sure whether that adds vital information. If a maintainer picks
> a patch that has been reviewed by others, they may or may not do a
> proper review themselves; but the end result is basically the same
> (patch makes its way into the tree.)

Okay. There's also the counter argument that too much text makes it 
something that no one will want to spend time reading, so leaving things 
concise is desirable.

> > At any rate, I like the idea of adding the additional descriptions for
> > the categories, even if we still bike-shed on the wording or even the
> > set of categories to use.
>
> What about going with this as a starting point?

Yes, works for me. We can always add more patches later if desired.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org