Re: [Qemu-devel] [PATCH v7 0/7] qmp: add pmemload command

[Eric Blake]

On 11/15/18 7:22 AM, Simon Ruderich wrote:
> Hello again,
>
> Please ignore v6, I forgot one patch. I hope I got it right this
> time.

Our automated tooling doesn't spot patches sent in reply to an earlier 
series; you may want to repost v7 as a new top-level thread (not 
in-reply-to any earlier message) to makes sure it gets seen by patchew.

> As I got no replies to my last mails, here again the full patch
> set (rebased on current master) in the hope to get this merged.
> The first few patches are cleanup, the last two patches add the
> pmemload feature. Only 5/6 requires an ack (although all
> mentioned issues should be fixed), all other patches were already
> reviewed in the last round.
>
> If there's anything else I can do to get this merged, please tell
> me.
>
> Regards
> Simon Ruderich
>
> Simon Ruderich (7):
>    cpus: correct coding style in qmp_memsave/qmp_pmemsave
>    cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open
>    cpus: use size_t in qmp_memsave/qmp_pmemsave
>    hmp: use l for size argument in memsave/pmemsave
>    hmp: use F for filename arguments in memsave/pmemsave
>    qmp: add pmemload command
>    hmp: add pmemload command
>
>   cpus.c          | 81 ++++++++++++++++++++++++++++++++++++++++---------
>   hmp-commands.hx | 18 +++++++++--
>   hmp.c           | 16 ++++++++--
>   hmp.h           |  1 +
>   qapi/misc.json  | 20 ++++++++++++
>   5 files changed, 118 insertions(+), 18 deletions(-)
>
> No changes between v6 and v7, but v6 missed one patch.
>
> Diff between v5 and v7:
>
>      --- a/qapi/misc.json
>      +++ b/qapi/misc.json
>      @@ -1201,7 +1201,7 @@
>      #
>      # Returns: Nothing on success
>      #
>      -# Since: 3.1
>      +# Since: 3.2

Except the next release will be named 4.0, not 3.2 :)  (It's okay, 
there's a lot of mentions of 3.2 floating on the list right now, and 
we'll probably have to do a global search-and-replace at some point once 
we are into the new year)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org