Re: [Qemu-devel] [PATCH for-3.1] linux-user/sparc/signal.c: Remove dead code

[Peter Maydell]

On 15 November 2018 at 11:59, Laurent Vivier <address@hidden> wrote:
> On 15/11/2018 12:46, Peter Maydell wrote:
>> Coverity complains (CID 1390847) about some dead code in
>> do_sigreturn(). This is an if (err) clause that can never be
>> true, copied from the kernel (where __get_user returns an error).
>> The one code path that could report an error is in the
>> currently commented-out pseudocode for handling FPU register
>> restoring, so move the if into that comment (and fix the
>> broken indent in the comment in the process).
>>
>> (The new position for the error check is also the semantically
>> correct one -- we should not restore the signal mask from
>> the signal frame if we get an error here, so the check must
>> be done before set_sigmask(), not after.)
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>>  linux-user/sparc/signal.c | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>
> Reviewed-by: Laurent Vivier <address@hidden>
>
> Do you apply it directly to the master or do you want a linux-user pull
> request?

Applied to master, thanks.

-- PMM