Re: [Qemu-devel] [PATCH 0/2] virtio-9p: qmp interface for set/query io throttle for fsdev devices

[Greg Kurz]

On Mon, 12 Nov 2018 01:14:55 +0000
xiezhide <address@hidden> wrote:

> These patches provide the qmp interface, to set/query the io throttle
> status of the all fsdev devices that are present in a vm.
> Some of the patches also remove the
> duplicate code that was present in block and fsdev files.
> 
> Zhide Xie (2):
>   fsdev-qmp: qmp interface for set/query io throttle for fsdev devices.
>   fsdev-qmp: fix coding style issue
> 

Hi Zhide Xie,

This series seems to have some formatting issues, like the broken
indention in the diffstat below for example. Also, no message
threading, weird Sob lines:

Signed-off-by: x00390961 <address@hidden<mailto:address@hidden>>

and finally I couldn't even apply patch 1:

$ pwclient git-am 996225 
Applying patch #996225 using 'git am'
Description: [1/2] virtio-9p: qmp interface to set/query io throttle for fsdev 
devices
Applying: virtio-9p: qmp interface to set/query io throttle for fsdev devices

error: corrupt patch at line 36 <== this confirms that the patch has formatting 
issues.

Patch failed at 0001 virtio-9p: qmp interface to set/query io throttle for 
fsdev devices
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
'git am' failed with exit status 128


Not sure what mail client was used to send this (I don't see any indication
in the mail headers), but if it's not the case already, I suggest you use
git format-patch and git send-email.

I don't have much time, so I'll wait for the well-formatted v2 before
starting review :-)

> Makefile                                                |  20 +++-
> Makefile.objs                                       |   8 ++
> block/throttle.c                                   |   6 +-
> blockdev.c                                             |  96 +----------------
> fsdev/qemu-fsdev-dummy.c            |  11 ++
> fsdev/qemu-fsdev-throttle.c            | 144 +++++++++++++++++---------
> fsdev/qemu-fsdev-throttle.h           |   6 +-
> fsdev/qemu-fsdev.c                            |  29 ++++++
> hmp-commands-info.hx                     |  15 +++
> hmp-commands.hx                             |  15 +++
> hmp.c                                                     |  83 
> +++++++++++++--
> hmp.h                                                     |   4 +
> include/qemu/throttle-options.h    |   3 +-
> include/qemu/throttle.h                   |   4 +-
> include/qemu/typedefs.h                  |   1 +
> monitor.c                                               |   4 +
> qapi/block-core.json                           | 122 +---------------------
> qapi/fsdev.json                                     |  96 +++++++++++++++++
> qapi/qapi-schema.json                       |   1 +
> qapi/tlimits.json                                   |  89 ++++++++++++++++
> qmp.c                                                      |  12 +++
> util/throttle.c                                        | 224 
> ++++++++++++++++++++++++++--------------
> 22 files changed, 639 insertions(+), 354 deletions(-)
> create mode 100644 qapi/fsdev.json
> create mode 100644 qapi/tlimits.json
> 


> --
> 1.8.3.1