[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/22] hw/pvrdma: Set the correct opcode for
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/22] hw/pvrdma: Set the correct opcode for send completion |
Date: |
Sun, 11 Nov 2018 10:04:47 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Sat, Nov 10, 2018 at 08:21:51PM +0200, Marcel Apfelbaum wrote:
>
>
> On 11/8/18 6:08 PM, Yuval Shaia wrote:
> > opcode for WC should be set by the device and not taken from work
> > element.
> >
> > Signed-off-by: Yuval Shaia <address@hidden>
> > ---
> > hw/rdma/vmw/pvrdma_qp_ops.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
> > index 7b0f440fda..3388be1926 100644
> > --- a/hw/rdma/vmw/pvrdma_qp_ops.c
> > +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
> > @@ -154,7 +154,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
> > comp_ctx->cq_handle = qp->send_cq_handle;
> > comp_ctx->cqe.wr_id = wqe->hdr.wr_id;
> > comp_ctx->cqe.qp = qp_handle;
> > - comp_ctx->cqe.opcode = wqe->hdr.opcode;
> > + comp_ctx->cqe.opcode = IBV_WC_SEND;
>
> That is interesting, what should happen if the opcode in hdr is different?
> Maybe fail the operation?
openmpi builds its entire IB state machine on that, see here:
https://github.com/open-mpi/ompi/blob/3dc1629771177a883cd8f1be6e97ab152e0f4584/opal/mca/btl/openib/btl_openib_component.c#L3512
>
> Thanks,
> Marcel
>
> > rdma_backend_post_send(&dev->backend_dev, &qp->backend_qp,
> > qp->qp_type,
> > (struct ibv_sge *)&wqe->sge[0],
> > wqe->hdr.num_sge,
>
- Re: [Qemu-devel] [PATCH v2 08/22] hw/pvrdma: Set the correct opcode for recv completion, (continued)
- [Qemu-devel] [PATCH v2 07/22] hw/pvrdma: Make default pkey 0xFFFF, Yuval Shaia, 2018/11/08
- [Qemu-devel] [PATCH v2 10/22] json: Define new QMP message for pvrdma, Yuval Shaia, 2018/11/08
- [Qemu-devel] [PATCH v2 11/22] hw/pvrdma: Add support to allow guest to configure GID table, Yuval Shaia, 2018/11/08
- [Qemu-devel] [PATCH v2 09/22] hw/pvrdma: Set the correct opcode for send completion, Yuval Shaia, 2018/11/08
- [Qemu-devel] [PATCH v2 13/22] hw/pvrdma: Make sure PCI function 0 is vmxnet3, Yuval Shaia, 2018/11/08
[Qemu-devel] [PATCH v2 20/22] hw/pvrdma: Clean device's resource when system is shutdown, Yuval Shaia, 2018/11/08
[Qemu-devel] [PATCH v2 14/22] hw/rdma: Initialize node_guid from vmxnet3 mac address, Yuval Shaia, 2018/11/08
[Qemu-devel] [PATCH v2 18/22] hw/rdma: Remove unneeded code that handles more that one port, Yuval Shaia, 2018/11/08
[Qemu-devel] [PATCH v2 15/22] hw/pvrdma: Make device state depend on Ethernet function state, Yuval Shaia, 2018/11/08
[Qemu-devel] [PATCH v2 16/22] hw/pvrdma: Fill all CQE fields, Yuval Shaia, 2018/11/08