Re: [Qemu-devel] [PATCH v2 02/11] blockdev: Check @replaces in blockdev_mirror_common

[Eric Blake]

On 8/9/18 5:31 PM, Max Reitz wrote:
> There is no reason why the constraints we put on @replaces should be
> limited to drive-mirror.  Therefore, move the sanity checks from
> qmp_drive_mirror() to blockdev_mirror_common() so they apply to
> blockdev-mirror as well.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   blockdev.c | 55 ++++++++++++++++++++++++++++++++----------------------
>   1 file changed, 33 insertions(+), 22 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org