qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/4] check-help: visual and content improvements


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 4/4] check-help: visual and content improvements
Date: Fri, 9 Nov 2018 20:32:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 9/11/18 16:07, Cleber Rosa wrote:
The "check" target is not a target that will run all other tests
listed, so in order to be accurate it's necessary to list those that
will run.  The same is true for "check-clean".

Then, to give a better visual impression of the differences in the
various targets, let's add empty lines.

Finally, a small (and hopeful) grammar fix from a non-native speaker.

Signed-off-by: Cleber Rosa <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

---
  tests/Makefile.include | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index c0a341c923..552faf9bbe 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -3,7 +3,8 @@
  check-help:
        @echo "Regression testing targets:"
        @echo
-       @echo " $(MAKE) check                Run all tests"
+       @echo " $(MAKE) check                Run unit, qapi-schema, qtest and 
decodetree"
+       @echo
        @echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
        @echo " $(MAKE) check-qtest          Run qtest tests"
        @echo " $(MAKE) check-unit           Run qobject tests"
@@ -12,12 +13,13 @@ check-help:
        @echo " $(MAKE) check-block          Run block tests"
        @echo " $(MAKE) check-tcg            Run TCG tests"
        @echo " $(MAKE) check-acceptance     Run all acceptance (functional) 
tests"
+       @echo
        @echo " $(MAKE) check-report.html    Generates an HTML test report"
        @echo " $(MAKE) check-venv           Creates a Python venv for tests"
-       @echo " $(MAKE) check-clean          Clean the tests"
+       @echo " $(MAKE) check-clean          Clean the tests and related data"
        @echo
        @echo "Please note that HTML reports do not regenerate if the unit 
tests"
-       @echo "has not changed."
+       @echo "have not changed."
        @echo
        @echo "The variable SPEED can be set to control the gtester speed 
setting."
        @echo "Default options are -k and (for $(MAKE) V=1) --verbose; they can 
be"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]