[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports |
Date: |
Thu, 8 Nov 2018 19:48:29 +0100 |
On Thu, Nov 8, 2018 at 7:43 PM Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
> > On 8 November 2018 at 18:08, Philippe Mathieu-Daudé <address@hidden> wrote:
> >> Anyway there are no information about merge window in the wiki.
> >> When I started it was not easy to understand it and why patches sent when
> >> 'merge window is close' fall under the crap and are unnoticed, thus it is
> >> better to wait before to send, or resend them.
> >
> > The intention (not always something we succeed at) is that
> > maintainers should respond to patches, do review, etc, at
> > any point in our release cycle. During a release they might
> > reply to say "I won't get to reviewing this for a little while"
> > or "I'll take this patch once the trunk reopens for releases",
>
> In both cases, the maintainer remains responsible for tracking the
> patches.
>
> I believe the sane thing to do is to review patches as usual, and to
> queue the ones that are ready to go into the next release on a separate
> branch.
>
> > but they shouldn't just leave patch submitters with no response
> > at all...
>
> Yes, that's rude.
Thanks both to clarify your maintainer view.
I added this thread to my TODO and if nobody write about this in the
wiki I'll, but later.
Phil.
- [Qemu-devel] [PATCH] scripts: Remove unused python imports, Philippe Mathieu-Daudé, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Eduardo Habkost, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Peter Maydell, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Philippe Mathieu-Daudé, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Peter Maydell, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Philippe Mathieu-Daudé, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Peter Maydell, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports, Markus Armbruster, 2018/11/08
- Re: [Qemu-devel] [PATCH] scripts: Remove unused python imports,
Philippe Mathieu-Daudé <=