[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] disas/mips: Disassemble R5900 DIV[U]1,
From: |
Fredrik Noring |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] disas/mips: Disassemble R5900 DIV[U]1, M{F, T}{LO, HI}1 and MULT[U]1 |
Date: |
Wed, 7 Nov 2018 20:10:07 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Aleksandar,
> I am glad that you want to include QEMU disas support for R5900 - this
> area usually gets forgotten.
>
> But, as you can see, this MIPS feature is partially broken - it doesn't
> handle well overlapping opcodes, and the field "membership" is not taken
> into account at all. I think the feature should be fixed first, and then
> R5900 support added. In fact, the disassembler support in QEMU is almost
> independent on the emulation support (for the corresponding instructions)
> - so, we could add disassembler support for all R5900 instructions in one
> clean sweep, instead dividing that in "million" pieces.
>
> The key to the successful solution would be detecting what CPU is
> currently being emulated, and making disassembling decision based on that.
>
> Let's talk about that later.
Yes, the current disassembly table needs to be reworked, so let's postpone
the opcodes for the R5900.
> P.S. Sorry for misspelling your name on several occasions.
No problem!
Fredrik
- [Qemu-devel] [PATCH v2 04/12] target/mips: Support Toshiba specific three-operand MADD and MADDU, (continued)
- [Qemu-devel] [PATCH v2 04/12] target/mips: Support Toshiba specific three-operand MADD and MADDU, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 05/12] target/mips: Support R5900 three-operand MADD1 and MADDU1, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 06/12] tests/tcg/mips: Test R5900 three-operand MADD, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 07/12] tests/tcg/mips: Test R5900 three-operand MADD1, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 08/12] tests/tcg/mips: Test R5900 three-operand MADDU, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 10/12] disas/mips: Increase 'member of ISAs' flag holder size, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 11/12] disas/mips: Define R5900 disassembly constants, Fredrik Noring, 2018/11/01
- [Qemu-devel] [PATCH v2 12/12] disas/mips: Disassemble R5900 DIV[U]1, M{F, T}{LO, HI}1 and MULT[U]1, Fredrik Noring, 2018/11/01