Re: [Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add`

[Thomas Huth]

On 2018-11-07 09:49, Kashyap Chamarthy wrote:
> On Mon, Nov 05, 2018 at 12:20:05PM +0100, Thomas Huth wrote:
>> On 2018-10-30 13:35, Kashyap Chamarthy wrote:
>>> Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP
>>> equivalent, too.
>>>
>>> Suggested-by: Thomas Huth <address@hidden>
>>> Signed-off-by: Kashyap Chamarthy <address@hidden>
> 
> [...]
> 
>>> diff --git a/hmp.c b/hmp.c
>>> index 4975fa56b0..c3f3db7795 100644
>>> --- a/hmp.c
>>> +++ b/hmp.c
>>> @@ -2353,6 +2353,8 @@ void hmp_cpu_add(Monitor *mon, const QDict *qdict)
>>>      int cpuid;
>>>      Error *err = NULL;
>>>  
>>> +    error_report("cpu_add is deprecated, please use device_add instead");
>>> +
>>>      cpuid = qdict_get_int(qdict, "id");
>>>      qmp_cpu_add(cpuid, &err);
>>>      hmp_handle_error(mon, &err);
>>>
>>
>> I think you should also mention this explicitly in qemu-deprecated.texi,
>> too.
> 
> I think you mean I should explicitly mention that the HMP equivalent is
> also deprecated -- currently I only call out the QMP command:
> 'qemu-deprecated.texi'.
> 
> I saw that Eduardo already queued this series; maybe I can add a
> follow-up if it can't be tweaked before submitting a pull request.

Yes, a follow-up patch is perfectly fine for this.

 Thanks,
  Thomas